-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17803 site: popup menu for subpages #4027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ deployed to https://761a1cc9.cldr.pages.dev |
btangmu
previously approved these changes
Sep 6, 2024
- also formatted
@btangmu take a look now |
✨ deployed to https://faa11b76.cldr.pages.dev |
Tried out https://faa11b76.cldr.pages.dev/. Looks great
…On Fri, Sep 6, 2024, 09:04 github-actions[bot] ***@***.***> wrote:
✨ deployed to https://faa11b76.cldr.pages.dev
—
Reply to this email directly, view it on GitHub
<#4027 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMDUUOFBQFLUR6GKIS3ZVHHCBAVCNFSM6AAAAABNYZIYGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGM3TMNRWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
can i get a review on this one? |
macchiati
approved these changes
Sep 9, 2024
haytenf
pushed a commit
to haytenf/cldr
that referenced
this pull request
Sep 17, 2024
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17803
'popup' menu of subpages
@macchiati with position:absolute the menu was harder to access (it would disappear when trying to move over to it
ALLOW_MANY_COMMITS=true